Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Fetch runtime version with cuda-python instead of numba #1675

Open
wants to merge 4 commits into
base: branch-24.12
Choose a base branch
from
Open

[Improvement] Fetch runtime version with cuda-python instead of numba #1675

wants to merge 4 commits into from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 9, 2024 •
edited
Loading

Description

Closes #948

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner September 9, 2024 23:24
@github-actions github-actions bot added the Python Related to RMM Python API label Sep 9, 2024
harrism
harrism approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@harrism harrism added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 9, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Sep 10, 2024

Okay CI is failing is failing because cuda.cudart.getLocalRuntimeVersion() is raising a RuntimeError in cuda 11.8 devcontainer.

In [1]: from cuda import cudart

In [2]: cudart.getLocalRuntimeVersion()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[2], line 1
----> 1 cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/cudart.pyx:24961, in cuda.cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/ccudart.pyx:2365, in cuda.ccudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/_lib/ccudart/ccudart.pyx:2121, in cuda._lib.ccudart.ccudart._getLocalRuntimeVersion()

RuntimeError: Failed to dlopen libcudart.so.12

@Matt711 Matt711 mentioned this pull request Sep 10, 2024
Closed
@Matt711
Copy link
Contributor Author

Matt711 commented Sep 11, 2024

Okay CI is failing is failing because cuda.cudart.getLocalRuntimeVersion() is raising a RuntimeError in cuda 11.8 devcontainer.

In [1]: from cuda import cudart

In [2]: cudart.getLocalRuntimeVersion()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[2], line 1
----> 1 cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/cudart.pyx:24961, in cuda.cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/ccudart.pyx:2365, in cuda.ccudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/_lib/ccudart/ccudart.pyx:2121, in cuda._lib.ccudart.ccudart._getLocalRuntimeVersion()

RuntimeError: Failed to dlopen libcudart.so.12

We can merge this PR after NVIDIA/cuda-python#89 is closed.

@Matt711 Matt711 self-assigned this Sep 12, 2024
@Matt711 Matt711 changed the base branch from branch-24.10 to branch-24.12 September 24, 2024 12:41
@wence- wence- added the 0 - Blocked Cannot progress due to external reasons label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

Assignees

@Matt711 Matt711

Labels
0 - Blocked Cannot progress due to external reasons improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch runtime version with cuda-python instead of numba.
3 participants
@Matt711 @harrism @wence-